Skip to content

Conversation

@ianthirdweb
Copy link
Contributor

@ianthirdweb ianthirdweb commented Oct 3, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on updating the documentation and sidebar navigation for user details and security in the in-app wallet, including renaming sections and enhancing descriptions for better clarity and organization.

Detailed summary

  • Renamed the title in page.mdx from "Retrieving In-App Wallet User Details on the Server" to "Fetching User Details from the Server".
  • Updated sidebar entries in sidebar.tsx to include "Backend APIs" and "Security".
  • Changed the title in security/page.mdx from "How In-App Wallet works" to "In-App Wallet Security".
  • Revised the description in security/page.mdx to clarify protection of user's private keys.
  • Added new content in ecosystems/security/page.mdx about wallet creation, security measures, usage, and recoverability.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2024

⚠️ No Changeset found

Latest commit: 11be173

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 3, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Oct 3, 2024
@vercel
Copy link

vercel bot commented Oct 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 🛑 Canceled (Inspect) Oct 4, 2024 7:45pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Oct 4, 2024 7:45pm
thirdweb-www ⬜️ Skipped (Inspect) Oct 4, 2024 7:45pm
wallet-ui ⬜️ Skipped (Inspect) Oct 4, 2024 7:45pm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.96 KB (0%) 840 ms (0%) 679 ms (+21.79% 🔺) 1.6 s
thirdweb (cjs) 101.68 KB (0%) 2.1 s (0%) 1.1 s (+39.92% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 222 ms (+709.37% 🔺) 319 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 68 ms (+272.15% 🔺) 78 ms
thirdweb/react (minimal + tree-shaking) 17.23 KB (0%) 345 ms (0%) 187 ms (+73.73% 🔺) 531 ms

@codecov
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.61%. Comparing base (422a725) to head (11be173).
Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4911      +/-   ##
==========================================
- Coverage   47.61%   47.61%   -0.01%     
==========================================
  Files        1057     1057              
  Lines       57221    57224       +3     
  Branches     3924     3924              
==========================================
+ Hits        27246    27247       +1     
- Misses      29286    29288       +2     
  Partials      689      689              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from d13b9a2
packages 43.37% <ø> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 5 files with indirect coverage changes

Copy link
Member

@MananTank MananTank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove merge conflict markers and fix conflict

Signed-off-by: Ian Mukherjee <[email protected]>
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 3, 2024 16:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 3, 2024 16:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 3, 2024 16:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 4, 2024 08:28 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 4, 2024 08:28 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 4, 2024 08:28 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 4, 2024 08:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 4, 2024 08:40 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 4, 2024 08:40 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 4, 2024 08:41 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 4, 2024 08:41 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 4, 2024 19:28 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 4, 2024 19:28 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 4, 2024 19:28 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 4, 2024 19:29 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 4, 2024 19:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 4, 2024 19:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 4, 2024 19:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 4, 2024 19:29 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 4, 2024 19:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 4, 2024 19:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 4, 2024 19:29 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 4, 2024 19:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 4, 2024 19:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 4, 2024 19:29 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 4, 2024 19:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 4, 2024 19:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 4, 2024 19:29 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 4, 2024 19:29 Inactive
@joaquim-verges joaquim-verges merged commit 4dee169 into main Oct 4, 2024
27 checks passed
@joaquim-verges joaquim-verges deleted the ian/ecosystem-security branch October 4, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants